This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Remove wireless support in securedrop kernel config #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes IRDA, Bluetooth, WiFi, WiMax and TV
Ansible 2.4 is end-of life, upgrading to supported version
emkll
force-pushed
the
remove-wireless
branch
from
5228f30 to
fc7ad1a
Compare
|
This CI failure is likely related to the Ansible version bump:
It's useful to have that run in CI, so let's modify the role logic in order to accommodate. |
conorsch
suggested changes
Dec 18, 2018
With the switch to ansible 2.7, the latter would fail when the file already existed. Using the HTTP status return code should be more reliable here.
emkll
force-pushed
the
remove-wireless
branch
from
fc7ad1a to
e72a3a2
Compare
4 tasks
conorsch
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
Looks great. Tests are in freedomofpress/securedrop#4002, so continuing with review over there.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards freedomofpress/securedrop#2726
This config was obtained via
make menuconfigand unselecting the following options:Also updated Ansible to 2.6 series due to 2.4 being EOL, and used --generate-hashes to generate hashes for the modules installed.