Revert "Add intel-microcode package" #3955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aeb9f1d. intel-microcode is in trusty-security, however, the package on which in depends, iucode-tool is in trusty-multiverse. Because cron-apt will only pull in packages from trusty-security, iucode-tool cannot be installed, therefore intel-microcode cannot be installed, and securedrop-grsec is in a broken state.
|
Testing this one. |
redshiftzero
approved these changes
Dec 3, 2018
There was a problem hiding this comment.
After upgrade testing from 0.10.0, confirmed the issue is resolved:
vagrant@app-staging:~$ apt-cache policy linux-firmware-image-4.4.162-grsec
linux-firmware-image-4.4.162-grsec:
Installed: 4.4.162-grsec-1
Candidate: 4.4.162-grsec-1
Version table:
*** 4.4.162-grsec-1 0
500 https://apt-test.freedom.press/ trusty/main amd64 Packages
100 /var/lib/dpkg/status
vagrant@app-staging:~$ apt-cache policy linux-image-4.4.162-grsec
linux-image-4.4.162-grsec:
Installed: 4.4.162-grsec-1
Candidate: 4.4.162-grsec-1
Version table:
*** 4.4.162-grsec-1 0
500 https://apt-test.freedom.press/ trusty/main amd64 Packages
100 /var/lib/dpkg/status
vagrant@app-staging:~$ uname -r
4.4.162-grsec
|
@redshiftzero I get the same results for the above checks on an upgraded system from 0.10.0 to 0.11.0-rc2 - is this a valid test? |
|
@zenmonkeykstop what about the |
|
Yup, |
|
Installing the deb should resolve (and upgrade to 4.4.162, but it's not a complete test because it's not being pulled in by cron-apt) The only way to fully test this is by uploading the packages to apt-test, which I will do when we release rc3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #3954
Reopens #3663
Removes intel-microcode from the list of dependencies for securedrop-grsec:
intel-microcode is in trusty-security, however, the package on which in depends, iucode-tool is in trusty-multiverse. Because cron-apt will only pull in packages from trusty-security, iucode-tool cannot be installed, therefore intel-microcode cannot be installed, and securedrop-grsec is in a broken state.
Testing
To confirm #3954 is properly fixed, the package will need to be put on apt-test to ensure the cron-apt job installs the packages correctly (sans intel-microcode)
Deployment
Deployed via apt packages
Checklist
If you made changes to the system configuration:
If you made non-trivial code changes: