Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI bug where PR branch was not rebasing on develop #2932

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

redshiftzero
Copy link
Contributor

Status

Ready for review

Description of Changes

Fixes #2931.

Changes proposed in this pull request:

  • add back in rebase on develop for staging CI job

Testing

Verify the "Rebase on-top of latest develop" step runs in Circle

Deployment

CI only

Checklist

CI only

Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-io
Copy link

Codecov Report

Merging #2932 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2932   +/-   ##
========================================
  Coverage    85.24%   85.24%           
========================================
  Files           32       32           
  Lines         1952     1952           
  Branches       218      218           
========================================
  Hits          1664     1664           
  Misses         237      237           
  Partials        51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdca942...b77443c. Read the comment docs.

@redshiftzero redshiftzero merged commit e305cbd into develop Jan 26, 2018
@redshiftzero redshiftzero deleted the add-back-rebase branch January 26, 2018 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants