Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI staging job not rebasing on develop #2931

Closed
redshiftzero opened this issue Jan 25, 2018 · 1 comment
Closed

CI staging job not rebasing on develop #2931

redshiftzero opened this issue Jan 25, 2018 · 1 comment
Assignees
@redshiftzero
Labels
CI-specific bug

Comments

@redshiftzero
Copy link
Contributor

I noticed when trying to rerun the CI job in #2925 that rebasing on develop wasn't working. Inspecting further, it appears that the two jobs we had in CI staging-test-with-rebase and staging-test were mislabeled (staging-test rebased, staging-test-with-rebase did not). As such, when we recently removed staging-test, we removed the CI job that rebased on latest develop. This is my bad, I merged in #2515 during a hackathon and should have caught this during review.
@redshiftzero redshiftzero self-assigned this Jan 25, 2018
This was referenced Jan 25, 2018
Merged
Merged
@conorsch
Copy link
Contributor

Great catch, @redshiftzero, thanks for doing the git archaeology here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redshiftzero redshiftzero

Labels
CI-specific bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@conorsch @redshiftzero