ci: ci improvements #2515
ci: ci improvements #2515
Conversation
|
Just talked with @tmc about this at the hackathon - while most of these changes are solid, we don't want to skip EC2 tests in forks and show green builds as it will lead maintainers to believe the tests ran successfully |
|
To get staging tests to pass here, @tmc disabled building of SecureDrop in his Circle CI account. Otherwise he was getting failures like this one, due to the use of his own account being used to run the Circle CI tests (and the expected EC2-related creds not being present). |
| git fetch origin develop | ||
| git rebase origin/develop | ||
| git fetch upstream develop | ||
| git rebase upstream/develop |
| @@ -76,3 +120,6 @@ workflows: | |||
| - staging-test: | |||
| requires: | |||
| - docs-lint | |||
| - staging-test-with-rebase: | |||
There was a problem hiding this comment.
I agree that this is a good practice (running tests both on their own branch and rebasing on the target branch - this is what we do for Travis tests as well).
There was a problem hiding this comment.
Though this increases costs so @msheiny/@conorsch happy to re-evaluate later this week
Status
Ready for review
Description of Changes
Testing
circle job
Deployment
N/A
Checklist
N/A