Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development environment builds Rust code (optionally with live-reload) #6816

Closed
Tracked by #6399
legoktm opened this issue May 17, 2023 · 0 comments · Fixed by #6828
Closed
Tracked by #6399

Development environment builds Rust code (optionally with live-reload) #6816

legoktm opened this issue May 17, 2023 · 0 comments · Fixed by #6828
Assignees
Labels
Rust Issues that touch Rust code

Comments

@legoktm
Copy link
Member

legoktm commented May 17, 2023

Once the Sequoia migration introduces Rust code, we need to pre-compile that code and install it in the venv before launching the dev flask servers. This has been done in the oxidize branch already.

It would be nice if live-reload worked so that changing a Rust file would recompile the Rust code, install the wheel, and then trigger reload of the flask dev servers. But I could easily see this being more complicated than its worth and also I personally rarely use live reload functionality when developing my own Rust projects.

Blocked by:

@legoktm legoktm changed the title Development environment builds Rust code (optionally with live-reload) - (done in oxidize branch) Development environment builds Rust code (optionally with live-reload) May 17, 2023
@legoktm legoktm added the Rust Issues that touch Rust code label May 17, 2023
@zenmonkeykstop zenmonkeykstop moved this to Cycle Backlog in SecureDrop dev cycle May 19, 2023
legoktm added a commit that referenced this issue May 30, 2023
We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.
@legoktm legoktm self-assigned this May 30, 2023
@legoktm legoktm moved this from Cycle Backlog to In Progress in SecureDrop dev cycle May 30, 2023
legoktm added a commit that referenced this issue Jun 2, 2023
We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.
legoktm added a commit that referenced this issue Jun 2, 2023
We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.
@legoktm legoktm moved this from In Progress to Ready For Review in SecureDrop dev cycle Jun 5, 2023
@cfm cfm moved this from Ready For Review to Under Review in SecureDrop dev cycle Jun 5, 2023
legoktm added a commit that referenced this issue Jun 6, 2023
We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.
legoktm added a commit that referenced this issue Jun 6, 2023
We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.
legoktm added a commit that referenced this issue Jun 6, 2023
We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.
legoktm added a commit that referenced this issue Jun 6, 2023
We need to compile Rust code before we can launch the development
environment and run tests.

Add a build_redwood step to `securedrop/bin/dev-deps` that uses maturin
to build a wheel and install it into the securedrop-app-code virtualenv.

maturin is only needed at build time, so it is pinned in a new
`build-requirements.txt`

Fixes #6814.
Fixes #6816.
@cfm cfm closed this as completed in #6828 Jun 6, 2023
@github-project-automation github-project-automation bot moved this from Under Review to Done in SecureDrop dev cycle Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Issues that touch Rust code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants