Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

development server no longer hot-reloads on file changes #6784

Closed
cfm opened this issue Apr 27, 2023 · 6 comments · Fixed by #7120
Closed

development server no longer hot-reloads on file changes #6784

cfm opened this issue Apr 27, 2023 · 6 comments · Fixed by #7120

Comments

@cfm
Copy link
Member

cfm commented Apr 27, 2023

Description

After #6563, make dev no longer hot-reloads on file changes, because the immutable SDConfig doesn't carry the env attribute from config.py. (This regression was last encountered in #5594.)

Steps to Reproduce

Same as #5594.

Expected Behavior

Same as #5594.

Actual Behavior

Same as #5594.

Comments

The fix in #6669 (comment) is trivial, but I want to take a moment to see if there's an easy way to test for this regression (fool me once, fool me twice, etc.).

@uncleSlayer
Copy link

Can I work on this?

@cfm
Copy link
Member Author

cfm commented May 11, 2023 via email

@cfm cfm removed their assignment May 11, 2023
@uncleSlayer
Copy link

Thanks, I'm new to open source but I'll give me best. I'll let you know if I need anything.

@uncleSlayer
Copy link

I have applied the patch you mentioned in #6669 and reload works in my machine. But I don't know how to write tests (I don't understand how it is implemented in this repo to be specific). Can you point me to some resources where I can learn? Thanks

@uncleSlayer
Copy link

On Wed, May 10, 2023 at 08:55:40AM -0700, Siddhant Ota wrote: Can I work on this?
Sure; thanks your interest! You'll find the basic fix in <#6669 (comment)>. The goal here is to find out if we can add a test that checks that "env" is passed through as expected. Let us know if you have any questions.

I have applied the patch you mentioned in #6669 and reload works in my machine. But I don't know how to write tests (I don't understand how it is implemented in this repo to be specific). Can you point me to some resources where I can learn? Thanks

@cfm
Copy link
Member Author

cfm commented Feb 8, 2024

@uncleSlayer, I'm sorry I left you hanging here. What we want is a test in test_config.py that checks that the configuration includes the env attribute added by the patch to sdconfig.py.

Don't feel any pressure to come back to this after so long! I'll follow up in a week to close this out if we don't hear back from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants