Remove legacy updater

[eloquence]

Status

Ready for review

Description

Resolves #412

The preflight updater is now at feature parity with the cron job that fires every 24 hours to update VMs:

• We enforce updates before launching the client (Enforce updates on login via dom0 launcher app #396)
• We remind the user if updates have not been applied recently (Add security notification script sdw-notify #445)
• We apply the dom0 state as part of the update process (Apply dom0 state as part of updater #458)

Therefore, it is safe to remove the cron job at this time. This PR preserves the securedrop-login script, which enforces updates to the sd-viewer template on login, until #415 is resolved.

NOTE: Because it changes the contents of the RPM package, this PR bumps the RPM version.

Test plan

Preparatory steps

• Make sure you are using a workstation that has been previously provisioned from a different branch that includes the updater (e.g., master)
• Check out this branch in your dev VM, make clone it into dom0

Test plan

• Run make clean
• Confirm the following files do not exist (make clean logic is still removing them)
  • /srv/salt/securedrop-update
  • /usr/bin/securedrop-update
  • /etc/cron.daily/securedrop-update-cron (symlink)
• Run make all
• Confirm the following files do not exist (make clean logic is still removing them)
  • /srv/salt/securedrop-update
  • /usr/bin/securedrop-update
  • /etc/cron.daily/securedrop-update-cron (symlink)

Checklist

• make flake8 passes
• make test passes in dom0
  • I am seeing mismatches in the RPC policy test, which appear to be unrelated to this PR, which does not touch RPC policies.
• I have added/removed files, and have updated packaging logic in MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec

Attribution

This PR is based on #322, originally by @kushaldas.

[eloquence]

I've tested this PR and can confirm that it works as intended; until we land it, patching from this branch should be a viable workaround if you want to provision a workstation without the legacy updater getting in the way (#378) or conflicting with the preflight updater (#396).

[eloquence]

To cherry-pick this change without creating a new commit, as part of provisioning, you can use this command on the master branch:

git cherry-pick -n ..origin/remove_auto_updater

The change will be staged but not committed:

git diff --cached

Until we're ready to merge this, I'll keep it in sync with master.

[conorsch]

Minor comments, throughout. Haven't tested, but based on visual review, does what it says on the tin.

[conorsch]

Because the clean action ensures state=absent, it actually makes sense to preserve the entries here. Note that /srv/* items may still need to be removed, either here or via clean-salt.

[eloquence]

Done.

[eloquence]

Since this changes the RPM, it should bump the package version -- I've not done that for now, but will before promoting to "ready", once other dependencies for this PR are met.

[eloquence]

This is necessary as the directory was previously created as part of the setup.py run.

[eloquence]

(As an aside, %{_bindir} has a leading slash, so those sorts of uses resolve to //. That's a noop, but can omit the unnecessary / - which is also used in the original code - if that's preferred.)

[eloquence]

(Rebased to fix conflicts.)

[emkll]

After merging #458, the only thing that the cron job will is customization within templates themselves. Given the runtimes of the make all command and the ability for potential admins to manually apply those states, I think this is fine to merge now.

LGTM, thanks @eloquence and @kushaldas . Tested with provided test plan and additional steps (specifically staging scenario).

Development environment

• Run make clean
• Confirm the following files do not exist (make clean logic is still removing them)
  • /srv/salt/securedrop-update
  • /usr/bin/securedrop-update
  • /etc/cron.daily/securedrop-update-cron (symlink)
• Run make all
• make all completes without error
• Confirm the following files do not exist (make clean logic is still removing them)
  • /srv/salt/securedrop-update
  • /usr/bin/securedrop-update
  • /etc/cron.daily/securedrop-update-cron (symlink)
• make test: All tests pass

Staging Environment

• Build rpm on this branch
• Installs successfully in dom0
• securedrop-admin --apply completes successfully
• securedrop-update and /etc/cron.daily/securedrop-update-cron are absent