Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sd-workstation-updates tag is not used for anything #728

Closed
eloquence opened this issue Oct 13, 2021 · 0 comments · Fixed by #814
Closed

sd-workstation-updates tag is not used for anything #728

eloquence opened this issue Oct 13, 2021 · 0 comments · Fixed by #814
Assignees
@eloquence
Labels
updater

Comments

@eloquence
Copy link
Member

#376 introduced an sd-workstation-updates tag which was used for the legacy updater that ran as a cron job, but when the legacy updater was removed in #430, the tags stayed.

The GUI updater uses the list hardcoded in https://github.com/freedomofpress/securedrop-workstation/blob/main/launcher/sdw_updater_gui/Updater.py#L40-L49. We should settle on one approach and avoid maintaining two lists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eloquence eloquence

Labels
updater
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code removal, cleanup and small fixes freedomofpress/securedrop-workstation
1 participant
@eloquence