Skip to content
This repository has been archived by the owner on Jan 7, 2024. It is now read-only.

expose ETag in submission/reply downloads #96

Merged
merged 1 commit into from
Jun 20, 2019
Merged

expose ETag in submission/reply downloads #96

merged 1 commit into from
Jun 20, 2019

Conversation

redshiftzero
Copy link
Contributor

(i figured I'd do this one so that we can make a new release of securedrop-sdk after this is merged with the other change we want for this sprint: #95)

Closes #86

You can test interactively, or you can also just inspect the tests and existing test cassettes since the ETags headers are there in the requests/responses

Copy link
Contributor

@rmol rmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tests passed. Script outside of the test suite worked too, for both submissions and replies.

My only comment is that the HTTP header is "ETag", not "Etag". That's the way we're sending it from the server, and it matters not at all because Requests' header dict is case-insensitive, but I just can't help myself. 😞 I may have to file an issue for securedrop. 🙂

@redshiftzero
Copy link
Contributor Author

thanks for reviewing! your comment re: Etag case is a good flag, fortunately since in HTTP/1.1 header names are case insensitive as long as we are not expecting a certain case of the ETag header elsewhere in our codebase we shouldn't need to make any changes

@redshiftzero redshiftzero merged commit b78636f into master Jun 20, 2019
@redshiftzero redshiftzero deleted the etags branch June 20, 2019 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return ETag in download methods
2 participants