This repository has been archived by the owner on Jan 7, 2024. It is now read-only.
Fixes #93 raises the TimeOutErrors properly #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests against live API is failing due to freedomofpress/securedrop#4538, PR pending to fix |
|
note: it looks like to auto-close the open issue I believe the "Fixes #" needs to be in the PR description or commit message |
Yes, I always try to put it in the commit message (the message begins with that). I did the same even in this commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds tests for timeouts in
download_replyanddownload_submissioncalls.Fixes #93
How to test?
make testand also the steps mentioned in #93.