This repository has been archived by the owner on Jan 7, 2024. It is now read-only.
Add timeouts into the SDK #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
reviewed
May 9, 2019
sssoleileraaa
approved these changes
May 13, 2019
sdclientapi/__init__.py
Outdated
| submission.source_uuid, submission.uuid | ||
| submission.source_uuid, | ||
| submission.uuid, | ||
| timeout=timeout or self.default_download_timeout, |
There was a problem hiding this comment.
Does this work? Won't timeout get ignored since there isn't a {timeout} var in the string?
There was a problem hiding this comment.
Also do we want to pass a timeout to download_reply the way we do here for download_submission?
There was a problem hiding this comment.
Oh wow, I added that to the wrong place entirely. Good catch.
There was a problem hiding this comment.
Also I figured it's ok for now to not pass this to replies since realistically we aren't going to have huge replies.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
requests/ Qubes RPC