Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can no longer login in qubes after timeouts merge / securedrop-sdk 0.0.9 #375

Closed
redshiftzero opened this issue May 16, 2019 · 3 comments
Closed
Labels
bug Something isn't working qubes needed

Comments

@redshiftzero
Copy link
Contributor

Description

Login to external server no longer works on latest master (06df84c) after merge of #362

STR

  1. Set up the dev env in Qubes on latest master
  2. Run the client without passing --no-proxy

Expected behavior

I can log in to my staging server.

Actual behavior

AuthError

Comments

I have not debugged this yet, I inferred that the above was causing the problems by:

  1. Reverting back to securedrop-sdk==0.0.8
  2. Reverting back to bad39fa

It's unclear yet if the fix involves this repo or the corresponding change made in the SDK: freedomofpress/securedrop-sdk#80

I discovered this during test of my fix to #363 (will put a draft PR until the underlying issues here are resolved), which is another Qubes only issue. I'm going to file a PR to update our merge policies so that we are testing and catching these issues in Qubes prior to merge.

@redshiftzero redshiftzero added bug Something isn't working qubes needed labels May 16, 2019
@sssoleileraaa
Copy link
Contributor

This is a good reminder that we should be testing client changes in Qubes. Will remember to add that to PR test plans until it becomes the norm.

I got my qubes machine running and can help debug the timeouts issue.

@kushaldas
Copy link
Contributor

I can login to my environment using Qubes Proxy + securedrop sdk 0.0.9 on the latest master of the client repository.

@redshiftzero
Copy link
Contributor Author

OK thanks @kushaldas - this must have been a local error... will debug, closing this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qubes needed
Projects
None yet
Development

No branches or pull requests

3 participants