Skip to content
This repository has been archived by the owner on Jan 7, 2024. It is now read-only.

use latest pip-tools (see securedrop-debian-packaging#248) #162

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented Jul 30, 2021

Description

Rerun make update-pip-requirements with the latest pip-tools (see freedomofpress/securedrop-builder#248) so that we can retag 0.3.0 and push a new sdk release to pypi. Also fix bug on main when you delete .venv and rerun make venv:

Collecting pip>=20.0 (from pip-tools==5.3.1->-r dev-requirements.txt (line 149))
In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
    pip>=20.0 from https://files.pythonhosted.org/packages/7c/02/9ab8b431aca1b46fcc1ac830a5870a28a12ba1abfa681904b1d2da876a86/pip-21.2.1-py3-none-any.whl#sha256=da0ac9d9032d1d7bac69e9e301778f77b8b6626b85203f99edd2b545434d90a7 (from pip-tools==5.3.1->-r dev-requirements.txt (line 149))
make: *** [Makefile:7: venv] Error 1

@sssoleileraaa sssoleileraaa force-pushed the use-latest-pip-tools branch from 7cdf771 to 4a082b7 Compare July 30, 2021 20:44
@sssoleileraaa sssoleileraaa force-pushed the use-latest-pip-tools branch from 4a082b7 to 2379018 Compare July 30, 2021 20:56
@sssoleileraaa
Copy link
Contributor Author

sssoleileraaa commented Jul 30, 2021

Test Plan

  1. cd to your sdk project directory
  2. rm -r .venv
  3. make venv
  • confirm no more require-hashes mode error around pinning pip-tools with >=
  1. source .venv/bin/activate and run make update-pip-requirements
  • confirm you are using the latest version of pip-compile and see no errors

@zenmonkeykstop
Copy link
Contributor

Ran thru test plan, make update-pip-requirements completes successfully , but pip-tools version is 5.3.1, not latest.

Signed-off-by: Allie Crevier <[email protected]>
@sssoleileraaa sssoleileraaa force-pushed the use-latest-pip-tools branch from 2379018 to 461c52f Compare July 30, 2021 22:31
@sssoleileraaa
Copy link
Contributor Author

but pip-tools version is 5.3.1, not latest.

sry about that, pushed updated changes where it is pinned to 6.2.0 as expected

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan checks out, pip-tools at 6.2.0 (current latest)!

@zenmonkeykstop zenmonkeykstop merged commit fae22d7 into main Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants