Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support pip-tools>5.0.0 #248

Merged
merged 1 commit into from
May 11, 2021
Merged

support pip-tools>5.0.0 #248

merged 1 commit into from
May 11, 2021

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented May 11, 2021 •
edited by emkll
Loading

Description

Fixes #225

Skips code comments when checking dependency hashes

Test Plan

  1. See that CI passes
  2. Add @pip install -U pip-tools before using pip-compile in the makefile target update-pip-requirements for securedrop-proxy
  3. make update-pip-requirements
  4. python3 setup.py sdist
  5. Change directory over to this repo with this PR branch checked out
  6. Run PKG_PATH=/path/to/securedrop-proxy make build-wheels

@sssoleileraaa sssoleileraaa changed the title skip code comments when checking dependency hashes support pip-tools>5.0.0 May 11, 2021
This was referenced May 11, 2021
Closed
Merged
emkll
emkll approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes 225, thanks @creviera !

@emkll emkll merged commit 963db41 into main May 11, 2021
@emkll emkll deleted the fix-225-allow-latest-pip-tools branch May 11, 2021 21:45
@sssoleileraaa sssoleileraaa mentioned this pull request Jul 12, 2021
Merged
13 tasks
@sssoleileraaa sssoleileraaa mentioned this pull request Jul 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emkll emkll emkll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requirements generated with pip-tools > 5.0.0 not parseable by build scripts
2 participants
@sssoleileraaa @emkll