Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

remove Pipenv in favor of pip-tools, security updates #33

Merged
merged 5 commits into from
May 30, 2019
Merged

Conversation

redshiftzero
Copy link
Contributor

Closes #136
Closes #138

Testing

  • Verify hashes are the same from the removed Pipfile.lock compared to requirements.txt except the one dependency updated here
  • Verify dev setup works for you following README updates
  • Verify static analysis, CVE safety check, test jobs pass in CI

Required diff review

Check prior to merge

^ once all these PRs are approved, I'll take this off of draft mode

@kushaldas
Copy link
Contributor

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Approved. 🦄 🦄 🦄 🦄

@redshiftzero redshiftzero marked this pull request as ready for review May 28, 2019 17:15
@kushaldas kushaldas merged commit 16d668e into master May 30, 2019
@emkll emkll deleted the bye-pipenv branch July 14, 2020 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants