-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Pipenv in favor of pip-tools, security updates #372
Conversation
This will break the package building steps. As our package index (wheel builds) + debian packaging works based on |
Yep I know, see this message in the PR description (there's another branch in the debian packaging repo called
|
Ah, I assume it means that pipenv's new feature about updating only one package does not work as it should? |
43ed1b3
to
f02e3df
Compare
Reviewed SQLAlchemy 1.3.3 https://github.com/freedomofpress/securedrop-debian-packaging/wiki/SQLAlchemy-1.3.3 |
Reviewed urllib3 1.24.3 https://github.com/freedomofpress/securedrop-debian-packaging/wiki/urllib3-1.24.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good. Approved 🦄 🦄 🦄 🦄 🌈
to prevent developer confusion about which should get installed where
sqlalchemy>=1.3.0 due to CVE-2019-7548 and CVE-2019-7164 urllib>=1.24.2 due to CVE-2019-11324
(force pushed to resolve conflicts only) |
Closes #370
Closes #308
Closes #371
Testing
Required diff review
Check prior to merge