Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Washington Post #41

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Adds Washington Post #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
image := fpf.local/securedrop-https-everywhere-ruleset:$(shell cat latest-rulesets-timestamp)

DEFAULT_GOAL: rules

.PHONY: test-key
test-key: ## Generates a test key for development/testing purposes locally.
openssl genrsa -out key.pem 4096
Expand Down
Binary file added default.rulesets.1617642666.gz
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<html>
<a href='rulesets-signature.1614864041.sha256'>rulesets-signature.1614864041.sha256</a><br>
<a href='rulesets-signature.1617642666.sha256'>rulesets-signature.1617642666.sha256</a><br>
<a href='latest-rulesets-timestamp'>latest-rulesets-timestamp</a><br>
<a href='default.rulesets.1614864041.gz'>default.rulesets.1614864041.gz</a><br>
<a href='default.rulesets.1617642666.gz'>default.rulesets.1617642666.gz</a><br>
</html>
2 changes: 1 addition & 1 deletion latest-rulesets-timestamp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1614864041
1617642666
1 change: 1 addition & 0 deletions onboarded.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ www.thestar.com,torontostar.securedrop.tor.onion
tcfmailvault.info,bartongellman.securedrop.tor.onion
www.apache.be,apache.securedrop.tor.onion
www.2600.com,2600.securedrop.tor.onion
www.washingtonpost.com,washingtonpost.securedrop.tor.onion
Binary file added rulesets-signature.1617642666.sha256
View file
Open in desktop
Binary file not shown.
5 changes: 5 additions & 0 deletions rulesets/washington-post-securedrop-ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<ruleset name="The Washington Post">
<target host="washingtonpost.securedrop.tor.onion" />
<rule from="^http[s]?://washingtonpost.securedrop.tor.onion"
to="http://vfnmxpa6fo4jdpyq3yneqhglluweax2uclvxkytfpmpkp5rsl75ir5qd.onion" />
Copy link
Member

@eloquence eloquence Apr 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like NYT, WaPo redirects to HTTPS, but because we do not record this fact in the directory, our script always generates http:// URLs:

securedrop-https-everywhere-ruleset/sddir.py

Line 10 in 1b51226

DEFAULT_ONION_PROTOCOL = "http://" # We don't store protocol in the directory

If we want to change this behavior I think it should be done at the ruleset generation level; I've filed freedomofpress/securedrop.org#832 to discuss. Since we also point to http:// for NYT (another HTTPS onion) already and the security considerations appear minor (see issue), I don't consider this a reason to put this PR on hold.

</ruleset>