Adds Washington Post #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates the Makefile so that running "make" with no args rebuilds the rules.
|
(I'll review.) |
eloquence
reviewed
Apr 6, 2021
| <ruleset name="The Washington Post"> | ||
| <target host="washingtonpost.securedrop.tor.onion" /> | ||
| <rule from="^http[s]?://washingtonpost.securedrop.tor.onion" | ||
| to="http://vfnmxpa6fo4jdpyq3yneqhglluweax2uclvxkytfpmpkp5rsl75ir5qd.onion" /> |
There was a problem hiding this comment.
Like NYT, WaPo redirects to HTTPS, but because we do not record this fact in the directory, our script always generates http:// URLs:
If we want to change this behavior I think it should be done at the ruleset generation level; I've filed freedomofpress/securedrop.org#832 to discuss. Since we also point to http:// for NYT (another HTTPS onion) already and the security considerations appear minor (see issue), I don't consider this a reason to put this PR on hold.
eloquence
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Also updates the Makefile so that running "make" with no args rebuilds the rules. Closes #40.
Review Checklist
onboarded.txtare accuratedefault.rulesets.TIMESTAMP.gzhas been updated, extracting that file and inspecting the contents of the JSON file produces the expected rulesPath Prefix:https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/$BRANCH_NAMEindex.htmlhas been updated using./update_index.shPost-Deployment Checklist