Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference to Source Interface /journalist-key route #112

Conversation

DrGFreeman
Copy link
Contributor

Status

Ready for review.

Description of Changes

  • Description:

Update instructions to get GPG key to use the new /public-key route instead of /journalist-key which will be deprecated.

Testing

  • Verify the instructions in the Retrieve GPG Public Keys section of Rebuilding an Admin Workstation USB refer to /public-key instead of /journalist-key, specifically in the curl command of the following block:

    cd ~/Persistent/securedrop/install_files/ansible-base
    curl http://$(cat app-source-ths)/public-key > SecureDrop.asc
    gpg --import SecureDrop.asc
    

Release

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • Doc link linting (make docs-linkcheck) passed
  • You have previewed (make docs) docs at http://localhost:8000

Update instructions to get GPG key to use the new /public-key route
instead of /journalist-key which will be deprecated.
@DrGFreeman
Copy link
Contributor Author

DrGFreeman commented Nov 26, 2020

The proposed change updates the URL to that of the new route and is not backwards compatible.

I am not familiar with the release process and synchronization between the docs and application however I can see a potential issue where an admin of an instance that does not yet implement the new route tries to follow the instructions and fails to download the key.

An alternative would be to leave the /journalist-key route and add the -L option to the curl command so that it follows the redirection. This would make the instructions compatible with instances that implement the new /public-key route (and redirection of the /journalist-key route) and those that don't.

@eloquence, what do you think? I can easily make the change to the above alternative.

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on visual review, will merge once freedomofpress/securedrop#5651 has been re-reviewed and merged.

@zenmonkeykstop zenmonkeykstop merged commit ba94f5b into freedomofpress:main Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Interface /journalist-key route is being deprecated, update references to /public-key
2 participants