app: prevent duplicate file downloads at the UI level #974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #116.
This is a UI layer solution for the purpose of the beta to resolve the above issue where multiple clicks result in attempting to download a file multiple times (see
prevent-duplicate-jobs
for a generic approach for ensuring duplicate jobs in general cannot be added to the queue).Test Plan
LOGLEVEL=DEBUG ./run.sh
), attempt to download the file.time.sleep(2)
in the submission download endpoint server-side), keep clicking.You should see the following line only once. indicating that duplicated clicks did not result in duplicate
FileDownloadJob
s being enqueued:Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable: