Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecureDrop Client 0.2.1 #1127

Merged
merged 1 commit into from
Jul 20, 2020
Merged

SecureDrop Client 0.2.1 #1127

merged 1 commit into from
Jul 20, 2020

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Jul 16, 2020

Description

Towards #1125 .

Related packaging PR: freedomofpress/securedrop-builder#178

Test Plan

  • Changelog is accurate
  • Version strings are correctly updated with update_version.sh

@emkll emkll requested a review from sssoleileraaa July 16, 2020 15:52
@emkll emkll force-pushed the securedrop-client-021 branch from ed9778b to a087210 Compare July 16, 2020 15:53
changelog.md Outdated

* Delete source widgets for current sync update (#1114)
* Reduce minimum window size (#1103)
* Make sure source fingerprint is updated on sync (#1092)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#974 was merged and not released since 0.2.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(That was meant to say #975, sorry for the confusion)

@emkll emkll force-pushed the securedrop-client-021 branch 4 times, most recently from 21f76b1 to 79bb637 Compare July 16, 2020 21:20
sssoleileraaa
sssoleileraaa previously approved these changes Jul 16, 2020
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like all the user-facing changes since 0.2.0

(waiting on merge, 🚀 on monday)

@eloquence
Copy link
Member

Hm, there may have been some discussion that I missed - did we agree to exclude changes that aren't user-facing from the changelog.md? That would be a change compared with e.g. the 0.2.0 log. I personally think it's fine to err on being more comprehensive in the GitHub changelogs, and pare it down for other artifacts for public consumption (blog posts etc.).

@sssoleileraaa
Copy link
Contributor

sssoleileraaa commented Jul 16, 2020

I think it makes sense to skip refactors, like moving code from one place to another, running black/isort, or just adding a bunch of tests. But I have no objections if we want to include the rest of the changes since we released 0.2.0, which are (see 0.2.0...main):

@eloquence
Copy link
Member

eloquence commented Jul 16, 2020

There's also #975 which I think is significant (functional change, with user-facing implications - syncs may be slowed down by duplicate jobs - but no UI impact). For these two:

In SD Core we would probably group this under "Developer Workflow" since it does not change functionality.

@sssoleileraaa sssoleileraaa dismissed their stale review July 16, 2020 22:48

e88da72 is the merge commit for #975 and should go into the changelog. also eloquence has advice on creating a developer workflow section for the refactors. sorry for all the back-and-fort, emkll!

@emkll emkll force-pushed the securedrop-client-021 branch from 79bb637 to 43d2d73 Compare July 20, 2020 13:35
sssoleileraaa
sssoleileraaa previously approved these changes Jul 20, 2020
@emkll
Copy link
Contributor Author

emkll commented Jul 20, 2020

Thanks for the reviews, CI is passing on the new tag, merging! (see freedomofpress/securedrop-builder#178)

@emkll emkll merged commit 9c1f920 into main Jul 20, 2020
@emkll emkll deleted the securedrop-client-021 branch July 20, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants