app: fix conversation refresh/syncing #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushaldas
previously approved these changes
Mar 16, 2020
There was a problem hiding this comment.
Submission deleted via JI
- Login to client, click on a source
- Delete a single submission via the JI for that source
- You should see the submission be deleted from the conversation view after sync
- For good measure, try sending a reply from the JI and ensure it appears in the conversation view
File deleted via JI
Precondition: Submit a file as a source
- Login to client, click on a source
- Delete a single file via the JI for that source
- You should see the file be deleted from the conversation view after sync
- Now submit another file as a source
- You should see the new file appear in the conversation view after sync
- For good measure, try sending a reply from the JI and ensure it appears in the conversation view
- For good measure, try sending a message from the source and ensure it appears in the conversation view
The data directory also looks good, no old files on the disk. Needs a rebase.
redshiftzero
force-pushed
the
conv-view-refresh
branch
from
c3d840d to
29e24d0
Compare
|
thanks for review! rebased/retested/repushed on latest master (4f86a61) |
when we access the replies, messages, and files relationships on Source, a new query is not necessarily emitted by sqlalchemy. This means that we can access objects that have been deleted. To ensure that this is not the case, we can call expire_all on the session.
redshiftzero
force-pushed
the
conv-view-refresh
branch
from
29e24d0 to
eb76a2b
Compare
|
rebased/retested/repushed on latest master (8ab6101) |
6 tasks
Suggested by @rmol in private conversation to replace the expire_all
|
added a commit based on a comment from @rmol (and retested) |
kushaldas
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #891.
Fixes #939.
Test Plan
Submission deleted via JI
File deleted via JI
Precondition: Submit a file as a source
You should not see any of the behavior reported in freedomofpress/securedrop-workstation#494 (comment): the application should not crash with a SQLAlchemy exception, nor should there be any overlaid file widgets in the conversation view.
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable: