Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.2.1-deb] New file widget not created for upload after file deletion #891

Closed
eloquence opened this issue Mar 7, 2020 · 4 comments · Fixed by #937
Closed

[0.2.1-deb] New file widget not created for upload after file deletion #891

eloquence opened this issue Mar 7, 2020 · 4 comments · Fixed by #937
Assignees
Labels
bug Something isn't working release blocker

Comments

@eloquence
Copy link
Member

Originally reported here.

Steps to reproduce

  1. Start the client and log in (run via LOGLEVEL=DEBUG securedrop-client in sd-app)
  2. Load Tor Browser in sd-proxy and visit the Journalist Interface; log in there as well
  3. Load the Source Interface in a separate tab.
  4. Create a new source via the Source Interface with just a file upload.
  5. Wait for the client to sync. You should see the source with the file widget.
  6. Delete the individual file (not the whole source) for this new source in the Journalist Interface.
  7. Wait for the client to sync.
  8. You should see the empty state below (expected).
  9. Upload another file as the source.
  10. Wait for the client to sync.

Expected behavior

A file widget for the new file shows up in the client.

Actual behavior

The conversation area remains empty, but the preview snippet is updated.

Restarting the client or signing out resolves; the file widget for the new file is now displayed.

Screenshots

Empty state at step at step 8:
Screenshot_2020-03-06_16-12-16

State after sync finishes at step 10:
Screenshot_2020-03-06_16-14-06

Corresponding state of Journalist Interface after step 10:
Screenshot_2020-03-06_16-28-39

@eloquence eloquence added the bug Something isn't working label Mar 7, 2020
@eloquence eloquence changed the title [0.2.1-deb] New file widget not created for upload after deletion [0.2.1-deb] New file widget not created for upload after file deletion Mar 7, 2020
@eloquence
Copy link
Member Author

(I did not notice anything in the logs other than normal sync behavior; the fact that no sync is required for the client to recover to a correct state may suggest this is purely a UI level issue.)

@redshiftzero
Copy link
Contributor

Looks like this is a generic issue, we're not updating the conversation view when we sync

@redshiftzero
Copy link
Contributor

Another STR:

  1. Login to client, view source.
  2. Delete submission via JI.
  3. Wait for sync. The deleted submission does not disappear.

@redshiftzero
Copy link
Contributor

wip in branch conv-view-refresh refreshes the conversation view on the screen after a sync (to resolve the two STR here) and fixes the crasher described in #494 (comment), but not the overlaid FileWidget yet, currently investigating that:

Screen Shot 2020-03-13 at 5 08 30 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants