-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flicker on mouse over in download button. #792
Fix flicker on mouse over in download button. #792
Conversation
de8e216
to
dbd5c44
Compare
I'm unable to repro #791 in Qubes (R4.0) so i can't confirm this fixes it. Perhaps someone else can? Also, it would be helpful if system information could be documented somewhere in case this happens again. |
@creviera I was able to reproduce this on my Ubuntu 18.04 development laptop. |
However, the download icon behavior is not what I'm expecting (decoupled hover states again), testing whether this is a regression introduced by this PR or not. Edit: Nope, that's #804, and is unrelated to this PR. |
dbd5c44
to
c30aa54
Compare
Rebased and clarified the comment about random (but regular) crashes of the test suite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make it clear the requested changes are just this: #792 (review) (the removal of HoverMOve and the comment or a comment replacement with an issue link so we can work on repro'ing and track)
72ae1c7
to
d52cbe8
Compare
@creviera @eloquence all ready for review after Friday's force push. Apologies for not flagging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Fixes #791
A trivial change. Took a while to spot why the flicker was happening. Parenthesis to clarify logical order of precedence.
Test Plan
No unit test change needed. Eyeball Mk.1 used to confirm flickering no longer happens. 👀
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable: