Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flicker on mouse over in download button. #792

Merged
merged 5 commits into from
Mar 2, 2020

Conversation

ntoll
Copy link
Contributor

@ntoll ntoll commented Feb 11, 2020

Description

Fixes #791

A trivial change. Took a while to spot why the flicker was happening. Parenthesis to clarify logical order of precedence.

Test Plan

No unit test change needed. Eyeball Mk.1 used to confirm flickering no longer happens. 👀

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

  • I have submitted a separate PR to the packaging repo
  • No update to the packaging logic (e.g., AppArmor profile) is required for these changes
  • I don't know and would appreciate guidance

@sssoleileraaa
Copy link
Contributor

I'm unable to repro #791 in Qubes (R4.0) so i can't confirm this fixes it. Perhaps someone else can? Also, it would be helpful if system information could be documented somewhere in case this happens again.

@ntoll
Copy link
Contributor Author

ntoll commented Feb 13, 2020

@creviera I was able to reproduce this on my Ubuntu 18.04 development laptop.

@eloquence
Copy link
Member

I'm also still able to repro #791 in Qubes (easiest by DL'ing a large file, and then repeatedly mousing over the spinner).

I can also confirm that this PR fixes the issue for me (tested with 25aeb2c cherry-picked to unbreak client in Qubes). 🎉

@eloquence
Copy link
Member

eloquence commented Feb 13, 2020

However, the download icon behavior is not what I'm expecting (decoupled hover states again), testing whether this is a regression introduced by this PR or not.

Edit: Nope, that's #804, and is unrelated to this PR.

@ntoll ntoll force-pushed the download-flicker-fix branch from dbd5c44 to c30aa54 Compare February 13, 2020 10:50
@ntoll
Copy link
Contributor Author

ntoll commented Feb 13, 2020

Rebased and clarified the comment about random (but regular) crashes of the test suite.

@sssoleileraaa sssoleileraaa self-requested a review February 20, 2020 21:54
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make it clear the requested changes are just this: #792 (review) (the removal of HoverMOve and the comment or a comment replacement with an issue link so we can work on repro'ing and track)

@ntoll ntoll force-pushed the download-flicker-fix branch from 72ae1c7 to d52cbe8 Compare February 28, 2020 10:42
@ntoll
Copy link
Contributor Author

ntoll commented Mar 2, 2020

@creviera @eloquence all ready for review after Friday's force push. Apologies for not flagging this.

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sssoleileraaa sssoleileraaa merged commit 7e59366 into freedomofpress:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download icon flickers when mousing over spinner
3 participants