Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download icon flickers when mousing over spinner #791

Closed
eloquence opened this issue Feb 10, 2020 · 1 comment · Fixed by #792
Closed

Download icon flickers when mousing over spinner #791

eloquence opened this issue Feb 10, 2020 · 1 comment · Fixed by #792
Labels
bug Something isn't working ux

Comments

@eloquence
Copy link
Member

eloquence commented Feb 10, 2020 •
edited
Loading

When you mouse over an active "Downloading" spinner, the "Download" icon Screenshot from 2020-02-10 09-31-08 briefly flickers into view.

STR

  1. Download a sufficiently large file for the spinner to run for a while
  2. Mouse over spinner

Expected result

Nothing

Actual result

Download icon briefly flickers into view

Test environment

Reproduced with latest master on Ubuntu and with latest nightly in Qubes
@eloquence eloquence added bug Something isn't working ux labels Feb 10, 2020
@ntoll
Copy link
Contributor

ntoll commented Feb 10, 2020

Sounds like an event handler is firing (on mouse_over) which changes the download icon, only to be swiftly updated by the next animation frame.

@ntoll ntoll mentioned this issue Feb 11, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flicker on mouse over in download button. ntoll/securedrop-client
2 participants
@ntoll @eloquence