Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix and tests for issue #442 #778

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

ntoll
Copy link
Contributor

@ntoll ntoll commented Feb 6, 2020

Description

Fixes #442

Adds a new signal, slot and unit tests to ensure the timestamp is updated when new files or messages from the source arrive in the client.

Test Plan

Updated unit tests.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

  • I have submitted a separate PR to the packaging repo
  • No update to the packaging logic (e.g., AppArmor profile) is required for these changes
  • I don't know and would appreciate guidance

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your solution! This works and just needs a rebase.

Edit: Nvm on that rebase, I haven't seen that github feature before where it blocks because a branch is out of date even though it can do a fast-forward rebase.... Oooh this is because @redshiftzero just turned on that github feature

@sssoleileraaa sssoleileraaa self-requested a review February 6, 2020 23:21
@sssoleileraaa sssoleileraaa merged commit a8bacc5 into freedomofpress:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source timestamp not updating in UI
2 participants