Source timestamp not updating in UI

[sssoleileraaa]

Description

The timestamp in SourceWidgets are no longer updating in the UI

[redshiftzero]

ah looks like this is also true of the LastUpdatedDate in the SourceProfileShortWidget, i.e. the "seconds ago" part here won't update:

[redshiftzero]

seems like for each one of these situations adding 1. a QTimer and 2. a slot for updating the timestamp is the way to go here

[sssoleileraaa]

I just checked the server-side's last_updated values in the sources table and see that the value is not being updated when a source sends a new message. This would explain why it's not showing up correctly in the client.

[eloquence]

This has other implications e.g. for journalist notifications, so we've agreed to investigate last_updated behavior in core at a high priority as part of this sprint.

[ntoll]

I've just looked into this and observe the same behaviour mentioned by @creviera. As far as I can tell once the server side issue is fixed, "it should just work" ™️

[eloquence]

I just checked the server-side's last_updated values in the sources table and see that the value is not being updated when a source sends a new message. This would explain why it's not showing up correctly in the client.

I can't reproduce this in develop. What I'm doing is:

1. Spin up a development environment with make dev on latest master
2. Create a new source via the source UI
3. Submit a series of messages/documents as the source, and verify the last_updated timestamp in the Docker dev container (including with logout/login cycles)

Here's what I'm seeing as I'm sending new messages/documents:

sqlite> select journalist_designation,last_updated from sources where journalist_designation='ecstatic countrywoman';
ecstatic countrywoman|2020-02-04 20:01:43.698790
sqlite> select journalist_designation,last_updated from sources where journalist_designation='ecstatic countrywoman';
ecstatic countrywoman|2020-02-04 20:01:49.435621
sqlite> select journalist_designation,last_updated from sources where journalist_designation='ecstatic countrywoman';
ecstatic countrywoman|2020-02-04 20:01:58.341733
sqlite> select journalist_designation,last_updated from sources where journalist_designation='ecstatic countrywoman';
ecstatic countrywoman|2020-02-04 20:02:03.356957
sqlite> select journalist_designation,last_updated from sources where journalist_designation='ecstatic countrywoman';
ecstatic countrywoman|2020-02-04 20:02:10.194386
sqlite> select journalist_designation,last_updated from sources where journalist_designation='ecstatic countrywoman';
ecstatic countrywoman|2020-02-04 20:02:22.511501
sqlite> select journalist_designation,last_updated from sources where journalist_designation='ecstatic countrywoman';
ecstatic countrywoman|2020-02-04 20:02:32.010802
sqlite> select journalist_designation,last_updated from sources where journalist_designation='ecstatic countrywoman';

The timestamp is not updated when a journalist sends a reply, but I believe that's the expected behavior as it's currently tracking last activity by the source.

[sssoleileraaa]

it sounds like this is a misunderstanding of what "last activity" meant. i was expecting to see the "last activity" timestamp update when new replies were accepted by the server.

[eloquence]

@creviera Does the timestamp update as expected when there is activity by the source?

[ntoll]

It appears not:

Note how the timestamp on the source widget is updated, whereas the timestamp above the conversation isn't working.

However, if I restart the app, then the correct date is shown above the conversation. The problem appears to be the timestamp update doesn't happen when a new message is received from the server. I'll investigate and create a fix now.