Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sync on ui operations #721

Merged
merged 5 commits into from
Jan 22, 2020

Conversation

ntoll
Copy link
Contributor

@ntoll ntoll commented Jan 22, 2020

Description

Fixes #658.

The sync_api function is no longer called when a source is deleted or a source's starred attribute is changed. While the API call to affect such changes still takes place, local state for that specific change is updated only on a successful API call. This avoids downloading the complete state of all the sources each time only a single source is updated.

Test Plan

Unit tests updated appropriately. Manual "eyeball mk.1" checks also done. Please ensure this is the desired behaviour.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

  • I have submitted a separate PR to the packaging repo
  • No update to the packaging logic (e.g., AppArmor profile) is required for these changes
  • I don't know and would appreciate guidance

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as advertised

@sssoleileraaa sssoleileraaa merged commit 0914d92 into freedomofpress:master Jan 22, 2020
@rmol rmol mentioned this pull request Jan 28, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer sync on successful delete or star operation
2 participants