Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer sync on successful delete or star operation #658

Closed
sssoleileraaa opened this issue Dec 10, 2019 · 2 comments · Fixed by #721
Closed

No longer sync on successful delete or star operation #658

sssoleileraaa opened this issue Dec 10, 2019 · 2 comments · Fixed by #721

Comments

@sssoleileraaa
Copy link
Contributor

sssoleileraaa commented Dec 10, 2019

Description

Now that metadata syncs have been moved to the queue and are top priority, we should no longer call sync_api when it's not necessary. When a source successfully deletes, we should delete the source locally without calling sync_api. When a star successfully is updated, we should untoggle the star (with the current error messaging to the user) without calling sync_api.

@sssoleileraaa sssoleileraaa changed the title No longer sync on successful delete operation No longer sync on successful delete or star operation Dec 10, 2019
@redshiftzero
Copy link
Contributor

To redraw the UI element (e.g. the star) when this change is made, a signal should be emitted to update just the relevant widget (this is one of the reasons why sync_api is being used everywhere).

@ntoll
Copy link
Contributor

ntoll commented Jan 21, 2020

OK... I'm looking at this. I've already done the star updating. Onto delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants