Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure conversation items are updated when content changes #394

Merged
merged 2 commits into from
Jun 1, 2019

Conversation

redshiftzero
Copy link
Contributor

Description

Fixes #361

Test Plan

  1. Follow STR in Dowloaded/decrypted messages unavailable in UI #361, confirm bug is fixed
  2. Revert fix, make sure regression test fails

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎 50 lines of test for 1 line of code 💎 lgtm!

@sssoleileraaa
Copy link
Contributor

(also note that I tested this and it fixes #361)

@sssoleileraaa sssoleileraaa merged commit dd6ee5e into master Jun 1, 2019
@sssoleileraaa sssoleileraaa deleted the stale-convo-items branch June 1, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dowloaded/decrypted messages unavailable in UI
2 participants