Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dowloaded/decrypted messages unavailable in UI #361

Closed
heartsucker opened this issue May 7, 2019 · 5 comments · Fixed by #394
Closed

Dowloaded/decrypted messages unavailable in UI #361

heartsucker opened this issue May 7, 2019 · 5 comments · Fixed by #394
Assignees
Labels
bug Something isn't working

Comments

@heartsucker
Copy link
Contributor

After signing in to the app, rapidly changing the selected conversation prevents downloaded/decrypted messages from displaying

STR

  1. Boot dev container
  2. Boot app
  3. Sign in
  4. Immediately click Source A
  5. Immediately click Source B

Expected

Source A and Source B should show the content of their messages.

Actual

Source A and Source B show Message not yet available until a sync occurs (manual, timed)

Notes

This is likely related to #352 and was likely caused by #345. I could be wrong. I think the underlying cause is that the decryption signal never hits the widget because it is garbage collected.

@heartsucker heartsucker added the bug Something isn't working label May 7, 2019
@sssoleileraaa
Copy link
Contributor

Let's focus on the underlying cause. I think you're right about the decryption signal sometimes not making it to the widget, which will require more investigation.

More details

If you run through the STR above a handful of times, you will see that sometimes source messages load, and sometimes they don't, and sometimes only a couple replies load, and sometimes only a couple messages load. And this varies across sources.

All of this is "fixed" when you manually refresh.

@sssoleileraaa
Copy link
Contributor

More troubleshooting:

Sometimes, messages in the conversation view will return back to "Message not yet available" after they have already appeared in plaintext.

STR:

  1. start the client
  2. click on a source, see messages in plaintext
  3. click on a different source and go back to the previous source you had selected, see messages appear as "Message not yet available"

@eloquence
Copy link
Member

For the current (5/30-6/12) sprint, we've committed to a 4 hour time-boxed attempt to resolve; additional issues may be created as a result of that investigation.

@sssoleileraaa
Copy link
Contributor

sssoleileraaa commented May 31, 2019

Seeing:

.virtualenvs/securedrop-client-CFeBqBy8/lib/python3.5/site-packages/sqlalchemy/orm/persistence.py:1347: SAWarning: DELETE statement on table 'replies' expected to delete 5 row(s); 4 were matched.  Please set confirm_deleted_rows=False within the mapper configuration to prevent this warning.
  % (table.description, expected, rows_matched)

when restarting both the server and client after there has been a local reply

@redshiftzero
Copy link
Contributor

ah, that issue seems to be the same as #360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants