CSS bug in ConversationView #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
requested review from
heartsucker and
redshiftzero
as code owners
redshiftzero
approved these changes
Apr 12, 2019
| @@ -573,8 +578,18 @@ class MainView(QWidget): | |||
| and main context view). | |||
| """ | |||
|
|
|||
| CSS = ''' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Segfault when runing without sdc-client home dir option #304
This one line fixes the issue: 6d7e144
Does not fully resolve QTBUG-69204 - Upstream Qt stylesheet bug causes segmentation faults #273 because I don't fully understand iwhether or not this is related to Segfault when runing without sdc-client home dir option #304. See Comments below.
Summary of Changes
We now do not add CSS to the
ConversationViewwidget. There is a comment in the class docstring that points to Segfault when runing without sdc-client home dir option #304 saying not to add CSS here.I uncommented a line of code that loads
sdclient.cssand its corresponding comment about QTBUG-69204 - Upstream Qt stylesheet bug causes segmentation faults #273 frommain.pysince that is not actually where the problem seems to be happening. There's something about the way we have created our ConversationView that makes adding CSS to that widget unstable. There are upcoming PRs for refactoring and styling the ConversationView, so I feel fine with knowing only this much for now.I moved remaining CSS from old code into class variables, which unifies the new way of organizing CSS. This is just a refactor to make it easier to debug next time. Next CSS refactor will probably move these strings into a CSS file.
Test
See STR in #304 (basically just run the client without passing the
sdc-homeoption and select a source to verify that a segfault does not occur.