Segfault when runing without sdc-client home dir option

[sssoleileraaa]

Description

Segfault happens when you run the client with no sdc-home option.

Logs (not much to go on)

./run.sh: line 44: 21070 Segmentation fault      exec python -m securedrop_client --sdc-home "$SDC_HOME" --no-proxy $@

More info

This looks like the same upstream bug that we came up with a workaround for. This might have been re-introduced when moving CSS from instance to class variables. See #273 for more info.

[redshiftzero]

I can't reproduce this on latest master (8f69f01), my STR are just to execute ./run.sh - do I need to login or take another action?

[sssoleileraaa]

Ah, sorry. Forgot the STR...

STR

1. ./run.sh
2. select a source

Do the same with the sdc-home option (this is how I normally test as I develop but will start testing both situations to catch bugs like this sooner) and see it not segfault

[redshiftzero]

ahh gotcha, I can indeed reproduce this on master with Qt 5.12.1