Remove quotation marks around .desktop entry name

[rocodes]

Status

Ready for review

Description

I think this will fix freedomofpress/securedrop-workstation#1123 . Qubes sanitizes desktop files to only allow certain characters, and we're violating that in the Name field, where we use quotation marks.

Test Plan

• Visual review
• make lint-desktop passes
• qubes.GetAppMenus on a VM with this desktop file generates no warnings

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

• I have tested these changes in the appropriate Qubes environment
• I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
• These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

• I have updated the AppArmor profile
• No update to the AppArmor profile is required for these changes
• I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

• I have written a migration and upgraded a test database based on main and confirmed that the migration is self-contained and applies cleanly
• I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
• I need help writing a database migration
• No database schema changes are needed

[cfm]

@rocodes, can you clarify the test plan here in terms of what output is expected with and without this change? I didn't catch the warning in freedomofpress/securedrop-workstation#1123 during initial provisioning, but qvm-sync-appmenus sd-{app,devices} does not give me any warnings running unmodified from Workstation 1.0.0-rc2 and Client 0.11.0-rc1 packages.

[deeplow]

Fixes the issue. LGTM.

[legoktm]

LGTM, but mostly per @deeplow.