Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message during provisioning indicates we're not creating qubes-appmenus entry for send-to-usb.desktop #1123

Closed
1 task done
rocodes opened this issue Jul 3, 2024 · 0 comments · Fixed by freedomofpress/securedrop-client#2086

Comments

@rocodes
Copy link
Contributor

rocodes commented Jul 3, 2024

  • I have searched for duplicates or related issues

Description

Noticed testing #1112 :

In the Creating appmenus stage of the provisioning, multiple warnings about the send-to-usb.desktop file are printed, meaning I think our file is somehow malformed vs what Qubes expects:

Warning: ignoring key 'Name' of send-to-usb
[...]
Warning: not creating/updating '/home/<redacted $USER>/.local/share/qubes-appmenus/sd-large-bookworm-template/apps.templates/send-to-usb.desktop' because of missing 'Name' key`

The first warning line is us hitting this, second is this, because we ignored the Name key. This code is executed during the qubes.GetAppMenus rpc service call.

The plot thickens: yes we should figure out why qubes-desktop-linux-common thinks our desktop file is malformed (I think maybe the quotation marks?) and throwing warnings, but we may not actually want an appemnu created in the template anyway for this because it's not meant to be invoked any other way than via our rpc calls.

(/usr/share/applications/send-to-usb.desktop is created)

Steps to Reproduce

Please specify your environment if that is necessary to reproduce the bug (if in doubt, include it).

Expected Behavior

No warnings during provisioning

Actual Behavior

Warning, as above

Comments

Suggestions to fix, any other relevant information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant