Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defect #174: application crash on source collection deletion #176

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

redshiftzero
Copy link
Contributor

@redshiftzero redshiftzero commented Nov 15, 2018

Closes #174

One should follow the STR in that issue to test this fix

@redshiftzero redshiftzero requested a review from emkll November 15, 2018 19:03
@zenmonkeykstop
Copy link
Contributor

Takin' a look at this now

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this in Qubes, refreshing the client after deletion no longer crashes the client when the source collection is deleted on the Journalist interface.

@zenmonkeykstop
Copy link
Contributor

Tested according to STR, looks good, client no longer crashes or throws any errors when source is deleted in JI and refresh is clicked.

@redshiftzero
Copy link
Contributor Author

great! thanks for QAing this both @zenmonkeykstop and @emkll

@redshiftzero redshiftzero merged commit 637ad6b into master Nov 15, 2018
@redshiftzero redshiftzero deleted the fix-src-delete-crash branch November 15, 2018 22:38
legoktm pushed a commit that referenced this pull request Dec 15, 2023
Update version and changelog for securedrop-client 0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing a collection in the JI causes the client to crash on next refresh
3 participants