Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a collection in the JI causes the client to crash on next refresh #174

Closed
zenmonkeykstop opened this issue Nov 15, 2018 · 0 comments · Fixed by #176
Closed

Removing a collection in the JI causes the client to crash on next refresh #174

zenmonkeykstop opened this issue Nov 15, 2018 · 0 comments · Fixed by #176
Assignees
Labels
bug Something isn't working
Milestone

Comments

@zenmonkeykstop
Copy link
Contributor

To reproduce:

  • add a source with some messages, files
  • view the source conversation in the client
  • delete the source in the JI
  • click refresh in the client.

Client deletes collection, then crashes with a db-related error:

Running app with home directory: /home/user/test_data_dir
Traceback (most recent call last):
  File "/home/user/securedrop-client/securedrop_client/logic.py", line 424, in update_conversation_view
    self.session.refresh(self.gui.current_source)
  File "/home/user/.local/share/virtualenvs/securedrop-client-g9KXN1tj/lib/python3.5/site-packages/sqlalchemy/orm/session.py", line 1498, in refresh
    self._expire_state(state, attribute_names)
  File "/home/user/.local/share/virtualenvs/securedrop-client-g9KXN1tj/lib/python3.5/site-packages/sqlalchemy/orm/session.py", line 1600, in _expire_state
    self._validate_persistent(state)
  File "/home/user/.local/share/virtualenvs/securedrop-client-g9KXN1tj/lib/python3.5/site-packages/sqlalchemy/orm/session.py", line 2047, in _validate_persistent
    state_str(state))
sqlalchemy.exc.InvalidRequestError: Instance '<Source at 0x3acaf98fda0>' is not persistent within this Session
@eloquence eloquence added the bug Something isn't working label Nov 15, 2018
@redshiftzero redshiftzero self-assigned this Nov 15, 2018
@redshiftzero redshiftzero added this to the 0.1.0alpha milestone Nov 15, 2018
redshiftzero added a commit that referenced this issue Nov 15, 2018
Fix defect #174: application crash on source collection deletion
legoktm pushed a commit that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants