Merge securedrop-sdk #1746
Merged
Merge securedrop-sdk #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use urljoin instead of string concat for urls. Thank you for the patch @vivekanand1101 👍
securedrop-sdk 0.0.2
Enable Replies to be instantiated using only a UUID
securedrop-sdk 0.0.3
Fixes #37, get stderr text in our process in Qubes
Parse reply UUID
fix #30: changed incorrect error msg when downloading a file
Rename sd-journalist to sd-proxy
securedrop-sdk 0.0.4
(Based on work done during 2018-11-12 documentation sprint by @redshiftzero @conorsch @emkll @eloquence)
Update README with additional context
This will ensure pipenv lock command does not update package versions unless explicitly specified in the Pipfile. Since we have automatic security checks for vulnerabilities in python libraries, this will ensure more consistency when building and testing our packages, and avoid drift in our requirements.txt and Pipfile.lock files.
The other SecureDrop Workstation components already use the built-in "safety" checks via `pipenv check` in CI, adding here for parity.
Pin library versions in Pipfile
Adds optional client side uuid selection for replies
Updates to release 0.0.5
Instead of being a separate pip package, this will just be part of the client itself.
legoktm
force-pushed
the
merge-sdk
branch
13 times, most recently
from
fe7d87c to
3f1fe7f
Compare
2 tasks
|
This will need a rebase after #1751 but otherwise ready for review. |
Rename all the imports and update the tests to reference `securedrop_client.sdk` instead of the pip-installed package.
Requiring 100% means we end up writing useless tests for the purposes of reaching that threshold, let's lower it to 90% as something that's substantially high but not requiring perfection.
This is the same as the `test-against-latest-api` CircleCI job in the sdk repository.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review; depends on freedomofpress/securedrop#7098
Description
Test plan