You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Minor developer confusion issue for maintainability:
We have objects with the same name (e.g. source), that are in some cases SDK objects, and in others ORM objects (i.e. rows from the client database).
We should make these variables names distinct, i.e. instead of source, we use source_db_object and source_sdk_object to be crystal clear what they are in each case.
Thoughts?
The text was updated successfully, but these errors were encountered:
I'm closing this because type annotations make this clearer (we've been importing the SDK objects as e.g. SDKSource for the purpose of type annotations)
Minor developer confusion issue for maintainability:
We have objects with the same name (e.g.
source
), that are in some cases SDK objects, and in others ORM objects (i.e. rows from the client database).We should make these variables names distinct, i.e. instead of
source
, we usesource_db_object
andsource_sdk_object
to be crystal clear what they are in each case.Thoughts?
The text was updated successfully, but these errors were encountered: