Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use different variable names for SDK and ORM objects #45

Closed
redshiftzero opened this issue Oct 18, 2018 · 1 comment
Closed

use different variable names for SDK and ORM objects #45

redshiftzero opened this issue Oct 18, 2018 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@redshiftzero
Copy link
Contributor

Minor developer confusion issue for maintainability:

We have objects with the same name (e.g. source), that are in some cases SDK objects, and in others ORM objects (i.e. rows from the client database).

We should make these variables names distinct, i.e. instead of source, we use source_db_object and source_sdk_object to be crystal clear what they are in each case.

Thoughts?

@redshiftzero redshiftzero added this to the 0.1.0beta milestone Nov 5, 2018
@redshiftzero redshiftzero added the help wanted Extra attention is needed label Nov 5, 2018
@redshiftzero
Copy link
Contributor Author

I'm closing this because type annotations make this clearer (we've been importing the SDK objects as e.g. SDKSource for the purpose of type annotations)

legoktm pushed a commit that referenced this issue Dec 11, 2023
legoktm pushed a commit that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant