-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh conversation view #142
Conversation
The source may have been updated in processing occuring in another thread.
Based on manually testing, the replies and messages can download pretty fast (especially if the gpg VM is already started)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work with ./run.sh
because the temp dir doesn't import the SD testing GPG key. We should just hard code that into this repo and add it during app start up. This would also make it easier to to encrypt to journalists during replies. I can add that on top of this if you want.
well that will import the SecureDrop test GPG key into the user's regular gpg keyring, which is a bit aggressive no? |
No, because it uses temporary directories. |
not for the GPG homedir, since we subprocess out to gpg in master right now and do not use a custom gpg homedir (any change we make to that must be qubes compliant) |
Ah ok so couldn't we pass the |
we could make the following change: in run.sh, if we're NOT on qubes we:
if we are on qubes we:
this does mean that in the decrypt functionality that is on master, we must pass through |
since the changes requested here related to the dev env, I propose we track and do in a followup |
heads up some of these dev env changes (e.g. importing the test key during run.sh) was implemented by josh over in the replies branch (#67) |
tracking my concerns in another issue
Closes #107
Test plan