Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh conversation view #142

Merged
merged 3 commits into from
Nov 14, 2018
Merged

Refresh conversation view #142

merged 3 commits into from
Nov 14, 2018

Conversation

redshiftzero
Copy link
Contributor

Closes #107

Test plan

  1. Login to client
  2. Click on source in sidebar
  3. The messages and replies are downloading... wait six seconds
  4. The messages and replies should appear decrypted in the conversation view. The user should not have to sync again or take any other manual action

The source may have been updated in processing occuring in another
thread.
Based on manually testing, the replies and messages can download
pretty fast (especially if the gpg VM is already started)
Copy link
Contributor

@heartsucker heartsucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work with ./run.sh because the temp dir doesn't import the SD testing GPG key. We should just hard code that into this repo and add it during app start up. This would also make it easier to to encrypt to journalists during replies. I can add that on top of this if you want.

@redshiftzero
Copy link
Contributor Author

well that will import the SecureDrop test GPG key into the user's regular gpg keyring, which is a bit aggressive no?

@heartsucker
Copy link
Contributor

No, because it uses temporary directories.

@redshiftzero
Copy link
Contributor Author

not for the GPG homedir, since we subprocess out to gpg in master right now and do not use a custom gpg homedir (any change we make to that must be qubes compliant)

@heartsucker
Copy link
Contributor

Ah ok so couldn't we pass the gpg_dir or something as a var and set it with --homedir if we're not in Qubes? Otherwise people are going to have to add it to their keyring anyway.

@redshiftzero
Copy link
Contributor Author

we could make the following change:

in run.sh, if we're NOT on qubes we:

  • add test key to a new dir: $SDC_HOME/gpg

if we are on qubes we:

  • do not add the test key
  • run the client without the --no-proxy arg

this does mean that in the decrypt functionality that is on master, we must pass through --homedir $SDC_HOME/gpg if we're using a temporary home directory, else we do not pass through a homedir

@redshiftzero
Copy link
Contributor Author

since the changes requested here related to the dev env, I propose we track and do in a followup

@redshiftzero redshiftzero requested a review from ntoll November 12, 2018 01:15
@redshiftzero
Copy link
Contributor Author

heads up some of these dev env changes (e.g. importing the test key during run.sh) was implemented by josh over in the replies branch (#67)

@heartsucker heartsucker dismissed their stale review November 13, 2018 21:33

tracking my concerns in another issue

@heartsucker heartsucker merged commit ab45363 into master Nov 14, 2018
@heartsucker heartsucker deleted the refresh-conversation-view branch November 14, 2018 17:54
legoktm pushed a commit that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants