Prevent UI flicker on conversation switch / update #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
reviewed
Jan 3, 2019
heartsucker
force-pushed
the
no-flicker
branch
from
9718dc1 to
105c5b8
Compare
redshiftzero
reviewed
Jan 8, 2019
heartsucker
force-pushed
the
no-flicker
branch
from
105c5b8 to
4418d22
Compare
heartsucker
force-pushed
the
no-flicker
branch
from
4418d22 to
889642d
Compare
heartsucker
force-pushed
the
no-flicker
branch
from
3c5e4c3 to
a1ad28b
Compare
redshiftzero
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185
This fixes the problem of the UI flickering every time there is a API sync or message-download-decrypt sync. This is done by caching the conversation views and swapping between them instead of dropping and recreating them.
(Also I updated some of the code and tests to try to logically separate code blocks to avoid walls of text because I found it hard to read some times)