Minimize sync db work #1036
Merged
Minimize sync db work #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmol
requested review from
sssoleileraaa,
kushaldas and
redshiftzero
as code owners
This was referenced Mar 31, 2020
Merged
|
(Per PR body, labeled |
Avoid dirtying synced objects on update unless they've actually changed, and reduce the number of commits.
rmol
force-pushed
the
minimize-sync-db-work
branch
from
7cb9a22 to
d8cae09
Compare
sssoleileraaa
approved these changes
Apr 1, 2020
| @@ -133,8 +133,21 @@ def update_local_storage(session: Session, | |||
| update_replies(remote_replies, get_local_replies(session), session, data_dir) | |||
|
|
|||
|
|
|||
| def update_sources(remote_sources: List[SDKSource], local_sources: | |||
| List[Source], session: Session, data_dir: str) -> None: | |||
| def lazy_setattr(o: Any, a: str, v: Any) -> None: | |||
| List[Source], session: Session, data_dir: str) -> None: | ||
| def lazy_setattr(o: Any, a: str, v: Any) -> None: | ||
| """ | ||
| Only assign v to o.a if they differ. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid dirtying synced objects on update unless they've actually changed, and reduce the number of commits.
This is based on and should be reviewed after #1035.
Test Plan
Run the SD core dev server. Ensure that syncing completes, that the source list and conversation view populate correctly, and that you can reply to sources.
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable: