-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer source key import #1035
Defer source key import #1035
Conversation
(Per PR body, labeled |
0b9bb0c
to
06e2801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After removing the unused GpgHelper from update_sources and update_local_storage, I think this is good to go! This change makes a lot of sense. We no longer import the source key until we call encrypt_to_source
. In the meantime I'll be checking out how much this improves performance. 🎉
Once #1039 is fixed this can be merged. |
Stop importing source GPG keys during sync. We have a place on Source to store fingerprint and key, which is all we need for the import, and which is what we check when deciding whether to enable the reply box, so let's just update the database here and defer import to the keyring until someone actually wants to reply. It takes milliseconds that won't be noticed then, but do add up during sync.
2b3717c
to
0cef1f5
Compare
Description
Stop importing source GPG keys during sync. We have a place on Source to store fingerprint and key, which is all we need for the import, and which is what we check when deciding whether to enable the reply box, so let's just update the database here and defer import to the keyring until someone actually wants to reply. It takes milliseconds that won't be noticed then, but do add up during sync.
This is based on and should be reviewed after #1034.
Test Plan
Run the SD core dev server. Run the client with
run.sh
and a fresh data directory. Ensure that you can still reply to sources. If you can, then deferring the key import until replying is working.Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable: