Fix truncation and alignment issues in conversation view

[sssoleileraaa]

Description

Fixes #998 (comment)
Fixes #694
Also download icon is no longer misaligned
Fixes #953

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

• I have tested these changes in the appropriate Qubes environment
• I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
• These changes should not need testing in Qubes

[sssoleileraaa]

(This does not fix #815)

[eloquence]

Good initial results in non-Qubes environment. Before:

After:

The attachment now has a bit less padding than before the change which does in fact seem to bring it closer to the spec, which also doesn't have a ton of padding here.

[eloquence]

OK the lack of padding when a file is the last thing is a bit extreme now:

[sssoleileraaa]

@eloquence is that a file submission without a message?

[eloquence]

Yes. Here's how that case is rendered in master:

[sssoleileraaa]

good catch there needs to more padding... i'll add that back

[eloquence]

More subtly, there's a small visual regression in the alignment between speech bubbles and file widgets, after a file has been downloaded -- note the alignment of "Export" before and after (the "E" should start where the speech bubble starts). Given the severity of the underlying issue, may be fine to accept to land this PR, but flagging in case it may have further unintended effects.

Before:

After:

[sssoleileraaa]

Download link no longer misaligned, see...

Before:

After:

[sssoleileraaa]

Addresses #1029 (comment):

[eloquence]

Can reproduce re: download link, looks like we're trading one alignment issue for another.

[sssoleileraaa]

what do you mean?

[eloquence]

Sorry, I mean yes, the Download link is now aligned with the speech bubble, and the Export link is not, whereas before it was the other way around (both should be aligned with the bubble).

[sssoleileraaa]

So just to be clear, this fixes the major file widget alignment issues on master, e.g.#998 (comment). The file widget would sometimes be much more misaligned than that.

That is a much bigger issue than #1029 (comment), which if you give me a few I can address.

[eloquence]

Yep agreed, this is a minor issue (and not even a full regression since it fixes a previous misalignment in the "Download" case) that can be fixed in follow-up if needed.

[eloquence]

Padding in "last interaction was a file upload" case now looks great:

[sssoleileraaa]

Addressed #998 (comment):

[eloquence]

Confirmed. Both Download and Export now perfectly aligned. :)

[sssoleileraaa]

did you add extra carriage returns at the top of the second message of #1029 (comment)? should we open an issue to think about truncating leading and following newlines?

[eloquence]

Ah yes, I did notice that before - that was a result of including whitespace in the clipboard, and yeah, I do think we should trim leading and trailing whitespace; I'll file a small enhancement issue for that. (Done: #1030)

[eloquence]

Looks good to me in Qubes testing as well, all my existing sources on my production instance still render correctly, and I am no longer able to reproduce the text truncation/squishing issue.

[conorsch]

Also confirming resolved over here. Tested on two different machines, so widget styling is slightly different.

Before

After

[kushaldas]

Looks good with different download option states, here is a screenshot.