-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file widget layout #694
Comments
Also, the spacing between file widgets grows after a download. This is a separate issue but related and also small. STR
|
@creviera this is (accidentally) fixed in #702 |
hey @ntoll i missed your comment from earlier, it looks like the file widget's bar and file size are out of alignment with the export and print buttons and filename. i just tested the latest changes on |
@creviera hah..! I remember obsessing over lining this stuff up. I wonder what's happened..? I'll take a look and get my screen ruler out. :-) |
So... I tried my best to evoke my Russian ballet teacher, with how this is spec'd. Imagine a terse woman with her hair drawn-back too tight, thwacking this mockup with a stick in-hand and occasionally barking indecipherable words atop an out of tune piano playing, as you review it. If that helps, that is. <3 Also:
|
I don't see more than subtle pixel differences in my non-Qubes env; this may be difficult to reproduce in its full severity without testing against a prod instance that exhibits pathological cases. Nonetheless flagging as candidate issue for @ntoll's last day to at least investigate what may be causing these offset issues. |
Hmm... I've had a look into this and I don't see any problems on my dev box. As far as I can tell:
Not sure what might be causing the Qubes related problem, but one though that occurred to me is that perhaps the fonts used by Qt in Qubes are different to the fonts (or different versions thereof) of those on my Ubuntu 18.04 LTS laptop. However, this definitely feels like I'm clutching at straws. |
Description
The file widget's bar and file size are out of alignment and the download bar is now not the right width, see:
The text was updated successfully, but these errors were encountered: