Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file widget layout #694

Closed
sssoleileraaa opened this issue Jan 10, 2020 · 9 comments · Fixed by #1029
Closed

Fix file widget layout #694

sssoleileraaa opened this issue Jan 10, 2020 · 9 comments · Fixed by #1029
Labels
bug Something isn't working

Comments

@sssoleileraaa
Copy link
Contributor

Description

The file widget's bar and file size are out of alignment and the download bar is now not the right width, see:
Screenshot from 2020-01-10 14-56-52

@sssoleileraaa sssoleileraaa added the bug Something isn't working label Jan 10, 2020
@sssoleileraaa
Copy link
Contributor Author

Also, the spacing between file widgets grows after a download. This is a separate issue but related and also small.

STR

  1. Send 3 files in a row as a source
  2. Download each file one by one from the client and see spacing grow

@ntoll
Copy link
Contributor

ntoll commented Jan 16, 2020

@creviera this is (accidentally) fixed in #702

@sssoleileraaa
Copy link
Contributor Author

hey @ntoll i missed your comment from earlier, it looks like the file widget's bar and file size are out of alignment with the export and print buttons and filename. i just tested the latest changes on master and it still looks like it does in the issue description. maybe it's not as obvious to others as it is to me, so here's a gif:

Peek 2020-02-03 18-30

@ntoll
Copy link
Contributor

ntoll commented Feb 4, 2020

@creviera hah..! I remember obsessing over lining this stuff up. I wonder what's happened..? I'll take a look and get my screen ruler out. :-)

@ntoll
Copy link
Contributor

ntoll commented Feb 4, 2020

@creviera screenie of new look:

file_hovers

@ninavizz
Copy link
Member

So... I tried my best to evoke my Russian ballet teacher, with how this is spec'd. Imagine a terse woman with her hair drawn-back too tight, thwacking this mockup with a stick in-hand and occasionally barking indecipherable words atop an out of tune piano playing, as you review it. If that helps, that is. <3

https://zpl.io/aw6K50n

Also:

  • The spacing between the end of the filename and the beginning of the line, as well as between the "r" in the word SERVER and the beginning of the line, should always remain the same.

@eloquence
Copy link
Member

eloquence commented Mar 25, 2020

See also the reports in #987, in particular, this extreme case ("1KB" trying to escape) reported by @ninavizz:

It wants to get away .. it wants to fly away ..

Worth testing on demo instance to see if others see this issue for that source. In my own testing, behavior appears consistent per source, so some widgets are better-behaved than others.

@eloquence
Copy link
Member

eloquence commented Mar 25, 2020

I don't see more than subtle pixel differences in my non-Qubes env; this may be difficult to reproduce in its full severity without testing against a prod instance that exhibits pathological cases. Nonetheless flagging as candidate issue for @ntoll's last day to at least investigate what may be causing these offset issues.

@ntoll
Copy link
Contributor

ntoll commented Mar 26, 2020

Hmm... I've had a look into this and I don't see any problems on my dev box.

As far as I can tell:

  • The spacing from the final word (such as "SERVER") and the line before the file size is always consistent on my machine.
  • Everything is aligned properly from a vertical point of view (see the very long filename in the screenie below).

Not sure what might be causing the Qubes related problem, but one though that occurred to me is that perhaps the fonts used by Qt in Qubes are different to the fonts (or different versions thereof) of those on my Ubuntu 18.04 LTS laptop. However, this definitely feels like I'm clutching at straws.

file-lineup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants