Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the addition of tooltips to most SecureQLabel occurrences #1016

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Mar 26, 2020

Description

Tooltips are only needed in the conversation view for long filenames that get truncated.

Fixes #1015.

Test Plan

Start the client. Confirm that tooltips are not shown for the preview snippets in the source list, or any content in the conversation view except for long filenames that need to be truncated. You'll need to upload a document with a long filename to test that.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

  • I have submitted a separate PR to the packaging repo
  • No update to the packaging logic (e.g., AppArmor profile) is required for these changes
  • I don't know and would appreciate guidance

sssoleileraaa
sssoleileraaa previously approved these changes Mar 26, 2020
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (tested and fixes the issue)

Tooltips are only needed in the conversation view for long filenames
that get truncated.
@sssoleileraaa sssoleileraaa merged commit 5ec5c7c into master Mar 27, 2020
@sssoleileraaa sssoleileraaa deleted the terrible-torrent-of-tooltips branch March 27, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltips shown for most SecureQLabels with long strings
2 participants