Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltips shown for most SecureQLabels with long strings #1015

Closed
eloquence opened this issue Mar 26, 2020 · 0 comments · Fixed by #1016
Closed

Tooltips shown for most SecureQLabels with long strings #1015

eloquence opened this issue Mar 26, 2020 · 0 comments · Fixed by #1016
Labels
bug Something isn't working

Comments

@eloquence
Copy link
Member

eloquence commented Mar 26, 2020 •
edited
Loading

#1006 suppressed tooltips on source previews, but we now show them for other long strings, including message bubbles and login errors. Screenshot helpfully provided by @ninavizz:

omgtooltip

The desired behavior is:

  1. Filenames: elide (a-very-long-filename-that-we-cannot-show-in-its-....) when too long, show tooltip iff elided
  2. Usernames: elide when too long, show tooltip iff elided
  3. Previews: elide when too long, do not show tooltip
  4. Everything else: do not elide, do not show tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert the addition of tooltips to most SecureQLabel occurrences freedomofpress/securedrop-client
1 participant
@eloquence