Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent tooltips on source preview labels #1006

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Mar 25, 2020

Description

Allow SecureQLabel to disable tooltips via the with_tooltip constructor argument, which if False will prevent tooltips being automatically set for the SecureQLabel when its setText method is called.

Set with_tooltip=False on SourceWidget's preview SecureQLabel so that no tooltip appears when hovering over it.

Fixes #999.

Test Plan

  • Check out this branch.
  • Run the client.
  • Verify that hovering over the preview labels in the source list does not produce any tooltips.
  • Upload a file with a very long name, download it in the client, and ensure that:
    • its name is truncated in the conversation view
    • its full name is shown in a tooltip if you hover over it

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

  • I have submitted a separate PR to the packaging repo
  • No update to the packaging logic (e.g., AppArmor profile) is required for these changes
  • I don't know and would appreciate guidance

Allow SecureQLabel to disable tooltips via the "with_tooltip"
constructor argument, which if False will prevent tooltips being
automatically set for the SecureQLabel when its setText method is
called.

Set "with_tooltip" False on SourceWidget's preview SecureQLabel so
that no tooltip appears when hovering over it.
redshiftzero
redshiftzero previously approved these changes Mar 25, 2020
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm redshiftzero dismissed my review, so restamping

@redshiftzero redshiftzero merged commit ed92b21 into master Mar 25, 2020
@redshiftzero redshiftzero deleted the suppress-preview-tooltip branch March 25, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source widget tooltip weirdness
2 participants