Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply gradient that spans the footprint behind the Source List, Conversation Pane, and Reply pane #299

Closed
sssoleileraaa opened this issue Apr 10, 2019 · 8 comments

Comments

@sssoleileraaa
Copy link
Contributor

@creviera The gradient that spans the footprint behind the Source List, the Conversation Pane, and the Reply pane, is below. It may be a tad light, ping me when ya get it in.

<?xml version="1.0" encoding="utf-8"?>
<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
	 viewBox="0 0 1224 792" style="enable-background:new 0 0 1224 792;" xml:space="preserve">
<style type="text/css">
	.st0{fill:url(#SVGID_1_);}
</style>
<radialGradient id="SVGID_1_" cx="609.095" cy="326.8184" r="279.7393" gradientTransform="matrix(2.065 0 0 1.9595 -644.4514 -243.4455)" gradientUnits="userSpaceOnUse">
	<stop  offset="0" style="stop-color:#F2F8F4"/>
	<stop  offset="0.4802" style="stop-color:#F2F3FA"/>
	<stop  offset="1" style="stop-color:#F8FCFF"/>
</radialGradient>
<rect x="1.9" y="0.5" class="st0" width="1222.9" height="792.9"/>
</svg>

Originally posted by @ninavizz in #280 (comment)

@sssoleileraaa sssoleileraaa changed the title Apply gradient that spans the footprint behind the _Source List_, the _Conversation Pane_, and the _Reply pane_ Apply gradient that spans the footprint behind the Source List, Conversation Pane, and Reply pane Apr 16, 2019
@eloquence eloquence added this to the 0.2.0alpha milestone Jul 2, 2019
@sssoleileraaa
Copy link
Contributor Author

@sssoleileraaa
Copy link
Contributor Author

@ninavizz Is this still the correct graient? #280 (comment). I can't find this gradient in the inventory list or in zeplin. Do you have a link?

@sssoleileraaa
Copy link
Contributor Author

to help, i can show you what the gradient provided in your comment looks like (granted this is not applied behind the sourcelist yet, which will require a code refactor to do):

gradient-hard-to-see

to make it easier to see that this is a radial gradient, i modified the colors (FOR DEMONSTRATION ONLY):

radial-gradient

@ninavizz
Copy link
Member

Yeeeeeahhh, no. As always, big affection & appreciation for your attention to detail! Lemme check...

@ninavizz
Copy link
Member

ninavizz commented Jul 26, 2019

Okee doke, now I remember why I created the gradient like that: because it has to span the full footprint beneath the Conversation Pane, and the Source List, and only the left 2/3 and the top 5/6th(ish) of that, are supposed to be regularly visible to users; with one leetle strip behind the Selected Source, visible. Just like we discussed when we strategized about this over lunch at Laurelhurst. The gradient needs to be like that so that the transition from the Conversation Pane into the Selected Source is smooth, while also giving the right chromatic "punch" in the Selected Source strip.

For a variety of reasons, I feel it's too much work to "incrementally" do the gradient. Which is why I've never liked this issue existing as a thing to tackle, before the typography, re-factoring of the Source List, or re-factoring of the Reply box. It's basically the last cherry-on-the-sundae touch in the UI, for us to worry about.

Happy to discuss in further detail, in Monday's meeting... but the rationale is too much to get into, in async typewritten communication.

@sssoleileraaa
Copy link
Contributor Author

sssoleileraaa commented Aug 1, 2019

The following issues get us closer to the desired design:

Once these are merged the client looks like... (click to expand)

background

no-content

no-source-selected

Which looks a whole lot better than this... (click to expand)

backgournd

no-content-before

no-source-selected-before

I am splitting this up into a couple follow-up issues, and will close this once the above PRs are merged. The follow-up issues are:

@eloquence
Copy link
Member

Thank you, @creviera! Let's aim to merge #505, #502, and #510 in this sprint, but bump the master issue off the sprint for now. Thanks to your hard work, we're already significantly exceeding the UI commitments for the sprint, and I think it's fine to defer the final work required to match the spec a bit longer, so we can use the remainder of the time in this sprint to focus on getting closer to resolving #391.

@eloquence eloquence modified the milestones: 0.2.0alpha, 0.2.0beta Dec 12, 2019
@eloquence
Copy link
Member

As noted above, was split into follow-up issues. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants