-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply gradient that spans the footprint behind the Source List, Conversation Pane, and Reply pane #299
Comments
Zeplin link for "No Content": https://app.zeplin.io/project/5c807ea562f734bd2756b243/screen/5cfe9244f033df15f09e72ec |
@ninavizz Is this still the correct graient? #280 (comment). I can't find this gradient in the inventory list or in zeplin. Do you have a link? |
Yeeeeeahhh, no. As always, big affection & appreciation for your attention to detail! Lemme check... |
Okee doke, now I remember why I created the gradient like that: because it has to span the full footprint beneath the Conversation Pane, and the Source List, and only the left 2/3 and the top 5/6th(ish) of that, are supposed to be regularly visible to users; with one leetle strip behind the Selected Source, visible. Just like we discussed when we strategized about this over lunch at Laurelhurst. The gradient needs to be like that so that the transition from the Conversation Pane into the Selected Source is smooth, while also giving the right chromatic "punch" in the Selected Source strip. For a variety of reasons, I feel it's too much work to "incrementally" do the gradient. Which is why I've never liked this issue existing as a thing to tackle, before the typography, re-factoring of the Source List, or re-factoring of the Reply box. It's basically the last cherry-on-the-sundae touch in the UI, for us to worry about. Happy to discuss in further detail, in Monday's meeting... but the rationale is too much to get into, in async typewritten communication. |
The following issues get us closer to the desired design: I am splitting this up into a couple follow-up issues, and will close this once the above PRs are merged. The follow-up issues are: |
Thank you, @creviera! Let's aim to merge #505, #502, and #510 in this sprint, but bump the master issue off the sprint for now. Thanks to your hard work, we're already significantly exceeding the UI commitments for the sprint, and I think it's fine to defer the final work required to match the spec a bit longer, so we can use the remainder of the time in this sprint to focus on getting closer to resolving #391. |
As noted above, was split into follow-up issues. Closing. |
@creviera The gradient that spans the footprint behind the Source List, the Conversation Pane, and the Reply pane, is below. It may be a tad light, ping me when ya get it in.
Originally posted by @ninavizz in #280 (comment)
The text was updated successfully, but these errors were encountered: